Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set-output throws error in ci/cd starting June 2023 #969

Merged

Conversation

venkatbandarupalli
Copy link
Contributor

This is required as set-output would be completely removed and the workflows can potentially break starting June 2023.

Fyi -
I am new to open source, however, I have some working knowledge on git and enterprise github.

I tried following the conventions as much as possible, please guide me if I have missed anything in this pull request.

thank you.

Signed-off-by: venkatbandarupalli <vbandarupalli19@gmail.com>
@github-actions
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6aee6e3) 15.10% compared to head (c2d5d02) 15.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #969   +/-   ##
=======================================
  Coverage   15.10%   15.10%           
=======================================
  Files          50       50           
  Lines        4667     4667           
=======================================
  Hits          705      705           
  Misses       3783     3783           
  Partials      179      179           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@HarikrishnanBalagopal HarikrishnanBalagopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HarikrishnanBalagopal HarikrishnanBalagopal merged commit 0298b0d into konveyor:main Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants