Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug where merging slice of interfaces introduced nils in the result #985

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

HarikrishnanBalagopal
Copy link
Contributor

No description provided.

Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
…the result

Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the fix label Mar 8, 2023
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.53 🎉

Comparison is base (0298b0d) 15.10% compared to head (9261680) 15.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #985      +/-   ##
==========================================
+ Coverage   15.10%   15.63%   +0.53%     
==========================================
  Files          50       52       +2     
  Lines        4667     4822     +155     
==========================================
+ Hits          705      754      +49     
- Misses       3783     3878      +95     
- Partials      179      190      +11     
Impacted Files Coverage Δ
common/deepcopy/merge.go 36.00% <100.00%> (ø)
common/deepcopy/deepcopy.go 23.63% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ashokponkumar ashokponkumar merged commit cc46576 into konveyor:main Mar 8, 2023
@HarikrishnanBalagopal HarikrishnanBalagopal deleted the fix/merge branch March 8, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: merge adds extra nil elements when merging slices with duplicate elements
2 participants