test: unit tests for podmanengine.go file in container package #997
Conversation
|
Thanks for making a pull request! 😃 |
| func (e *podmanEngine) InspectImage(image string) ([]types.ImageInspect, error) { | ||
| inspectcmd := exec.Command("podman", "inspect", image) | ||
| logrus.Debugf("Inspecting image %s", image) | ||
| output, err := inspectcmd.CombinedOutput() | ||
| if err != nil { | ||
| logrus.Debugf("Unable to inspect image %s : %s, %s", image, err, output) | ||
| return t, err | ||
| return nil, err | ||
| } | ||
| t = types.ImageInspect{} | ||
| var t []types.ImageInspect |
There was a problem hiding this comment.
Inspect functionality in podman returns an array of json, which can only be unmarshalled into a slice of structs.
Fixes this:
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #997 +/- ##
==========================================
+ Coverage 17.63% 18.15% +0.51%
==========================================
Files 52 52
Lines 4820 4820
==========================================
+ Hits 850 875 +25
+ Misses 3758 3727 -31
- Partials 212 218 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
It has to match this interface |
I've addressed this in the new commit. Please review. |
Signed-off-by: tarun8718 <tarunkumar8718@gmail.com>
HarikrishnanBalagopal
added
the
lfx-project
Signed-off-by: tarun8718 <tarunkumar8718@gmail.com>
|
Please use |
|
@ashokponkumar some tests (like run cmd in a container) requires functionalities like touch/sleep infinity; Such tests can't be run on hello-world as it doesn't have the support. In such case which image do I use? |
This PR consists of unit tests for podmanengine.go file in the container package.
Below are the tests and their test execution status:
