Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add a log msg to clarify a secret is required to deploy kai #378

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jmontleon
Copy link
Member

If the key does not exist it will print a message:

TASK [Verify kai-api-key-secret has been created] *******************************************************************************************************************************************************************************************
ok: [localhost] => {
    "msg": "Kai will not deploy until the credential secret exists. kubectl create secret -n konveyor generic kai-api-key-secret --fromliteral=genai_key=[BAM_KEY] --from-literal=api_base=[OPENAI_BASE] --from-literal=api_key=[OPENAI_KEY]\n"
}

PLAY RECAP **********************************************************************************************************************************************************************************************************************************
localhost                  : ok=2    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0  

@jmontleon jmontleon force-pushed the add-missing-secret-msg branch 3 times, most recently from 4f904c3 to 28b41d8 Compare September 11, 2024 15:26
debug:
msg: >
Kai will not deploy until the credential secret exists.
kubectl create secret -n {{ app_namespace }} generic kai-api-key-secret
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
kubectl create secret -n {{ app_namespace }} generic kai-api-key-secret
kubectl create secret -n {{ app_namespace }} generic {{ kai_api_key_secret_name }}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmontleon other than that lgtm

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, should be fixed!

Signed-off-by: Jason Montleon <jmontleo@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants