-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webhook exporter allowing Pelorus to work with push data model #836
Webhook exporter allowing Pelorus to work with push data model #836
Conversation
Skipping CI for Draft Pull Request. |
6ea110d
to
d18b63c
Compare
d18b63c
to
0f4e18a
Compare
0f4e18a
to
530ece9
Compare
a4a1d5d
to
f3b332d
Compare
8471e16
to
d00ce4b
Compare
b0a48f5
to
82a9457
Compare
Signed-off-by: Michal Pryc <mpryc@redhat.com> Signed-off-by: Mateus Oliveira <msouzaol@redhat.com> Signed-off-by: Michal Pryc <mpryc@redhat.com>
82a9457
to
af00ac6
Compare
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, the missing features will be implemented in following PRs, guided by the created issues
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mateusoliveira43 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Check README.md in the webhook folder.
Testing
Some testing instructions:
On one terminal:
On another terminal
Navigate to the endpoint:
http://localhost:8000/metrics
, you should see all the metrics collected:Also for testing a simple
make unit-tests
should do most of the job, as the coverage for the new functions is almost at 100%.Signed-off-by: Michal Pryc mpryc@redhat.com
@redhat-cop/mdt