[RFR][CR][JF] Fix tier3 failures (#820)

* Fix tier3 failures Signed-off-by: Shveta Sachdeva <sshveta@edhat.com> * Fix tier3 failures Signed-off-by: Shveta Sachdeva <sshveta@edhat.com> --------- Signed-off-by: Shveta Sachdeva <sshveta@edhat.com> Co-authored-by: Shveta Sachdeva <sshveta@edhat.com>
konveyor · Nov 20, 2023 · 716a89d · 716a89d
1 parent d0b7de4
commit 716a89d
Show file tree

Hide file tree

Showing 7 changed files with 105 additions and 233 deletions.
diff --git a/cypress/e2e/tests/migration/applicationinventory/manageimports/pagination.test.ts b/cypress/e2e/tests/migration/applicationinventory/manageimports/pagination.test.ts
@@ -27,7 +27,7 @@ import {
     deleteAppImportsTableRows,
     validatePagination,
 } from "../../../../../utils/utils";
-import { sideKebabMenuImports } from "../../../../views/applicationinventory.view";
+import { sideKebabMenu } from "../../../../views/applicationinventory.view";
 
 import * as commonView from "../../../../views/common.view";
 import { Application } from "../../../../models/migration/applicationinventory/application";
@@ -119,7 +119,7 @@ describe(["@tier3"], "Manage imports pagination validations", function () {
             .get("tbody")
             .find("td[data-label='File name']")
             .each(($tableRow) => {
-                click(sideKebabMenuImports);
+                click(sideKebabMenu);
                 cy.get("ul[role=menu] > li").contains("Delete").click();
                 click(commonView.confirmButton);
                 cy.wait("@deleteImport");

diff --git a/cypress/e2e/tests/migration/controls/businessservices/pagination.test.ts b/cypress/e2e/tests/migration/controls/businessservices/pagination.test.ts
@@ -25,6 +25,7 @@ import {
     deleteTableRows,
     deleteApplicationTableRows,
     deleteAllBusinessServices,
+    deleteAllItems,
 } from "../../../../../utils/utils";
 import { SEC } from "../../../../types/constants";
 import { prevPageButton } from "../../../../views/common.view";
@@ -81,7 +82,7 @@ describe(["@tier3"], "Business services pagination validations", function () {
         cy.wait(2 * SEC);
         goToLastPage();
         // Delete all items of last page
-        deleteTableRows();
+        deleteAllItems();
         // Verify that page is re-directed to previous page
         cy.get("td[data-label=Name]").then(($rows) => {
             cy.wrap($rows.length).should("eq", 10);

diff --git a/cypress/e2e/tests/migration/controls/jobfunctions/pagination.test.ts b/cypress/e2e/tests/migration/controls/jobfunctions/pagination.test.ts
@@ -22,13 +22,7 @@ import {
     deleteByList,
     validatePagination,
 } from "../../../../../utils/utils";
-import {
-    firstPageButton,
-    lastPageButton,
-    nextPageButton,
-    pageNumInput,
-    prevPageButton,
-} from "../../../../views/common.view";
+import { pageNumInput, prevPageButton } from "../../../../views/common.view";
 import { Jobfunctions } from "../../../../models/migration/controls/jobfunctions";
 let jobFunctionsList: Array<Jobfunctions> = [];
 
@@ -72,7 +66,7 @@ describe(["@tier3"], "Job functions pagination validations", function () {
         });
     });
 
-    it("Bug MTA-1675: Page number validations", function () {
+    it("Page number validations", function () {
         // Navigate to Job functions tab
         Jobfunctions.openList();
 

diff --git a/cypress/e2e/tests/migration/controls/stakeholdergroups/pagination.test.ts b/cypress/e2e/tests/migration/controls/stakeholdergroups/pagination.test.ts
@@ -18,19 +18,18 @@ limitations under the License.
 import {
     login,
     selectItemsPerPage,
-    deleteTableRows,
     createMultipleStakeholderGroups,
     validatePagination,
+    deleteAllStakeholderGroups,
+    deleteAllItems,
 } from "../../../../../utils/utils";
 import { Stakeholdergroups } from "../../../../models/migration/controls/stakeholdergroups";
 import { lastPageButton, pageNumInput, prevPageButton } from "../../../../views/common.view";
 
-let stakeholderGroupsList: Array<Stakeholdergroups> = [];
-
 describe(["@tier3"], "Stakeholder groups pagination validations", function () {
     before("Login and Create Test Data", function () {
         login();
-        stakeholderGroupsList = createMultipleStakeholderGroups(11);
+        createMultipleStakeholderGroups(11);
     });
 
     beforeEach("Interceptors", function () {
@@ -46,7 +45,7 @@ describe(["@tier3"], "Stakeholder groups pagination validations", function () {
         validatePagination();
     });
 
-    it("Items per page validations", function () {
+    it("Bug MTA-1694: Items per page validations", function () {
         // Navigate to stakeholder groups tab
         Stakeholdergroups.openList();
         cy.get("@getStakeholdergroups");
@@ -88,7 +87,7 @@ describe(["@tier3"], "Stakeholder groups pagination validations", function () {
         });
     });
 
-    it("Bug MTA-1675: Last page item(s) deletion, impact on page reload validation", function () {
+    it("Bug MTA-1694: Last page item(s) deletion, impact on page reload validation", function () {
         // Issue - https://issues.redhat.com/browse/TACKLE-155
         // Navigate to stakeholder groups tab
         Stakeholdergroups.openList();
@@ -103,7 +102,7 @@ describe(["@tier3"], "Stakeholder groups pagination validations", function () {
         cy.wait(2000);
 
         // Delete all items of last page
-        deleteTableRows();
+        deleteAllItems();
 
         // Verify that page is re-directed to previous page
         cy.get("td[data-label=Name]").then(($rows) => {
@@ -112,6 +111,6 @@ describe(["@tier3"], "Stakeholder groups pagination validations", function () {
     });
 
     after("Perform test data clean up", function () {
-        deleteTableRows();
+        deleteAllStakeholderGroups();
     });
 });
diff --git a/cypress/e2e/tests/migration/controls/stakeholders/pagination.test.ts b/cypress/e2e/tests/migration/controls/stakeholders/pagination.test.ts
@@ -18,9 +18,9 @@ limitations under the License.
 import {
     login,
     selectItemsPerPage,
-    deleteTableRows,
     createMultipleStakeholders,
     validatePagination,
+    deleteAllItems,
 } from "../../../../../utils/utils";
 import { lastPageButton, pageNumInput, prevPageButton } from "../../../../views/common.view";
 import { Stakeholders } from "../../../../models/migration/controls/stakeholders";
@@ -101,7 +101,7 @@ describe(["@tier3"], "Stakeholder pagination validations", function () {
         cy.wait(2000);
 
         // Delete all items of last page
-        deleteTableRows(stakeHoldersTable);
+        deleteAllItems(stakeHoldersTable);
 
         // Verify that page is re-directed to previous page
         cy.get("td[data-label=Email]").then(($rows) => {
@@ -110,6 +110,6 @@ describe(["@tier3"], "Stakeholder pagination validations", function () {
     });
 
     after("Perform test data clean up", function () {
-        deleteTableRows(stakeHoldersTable);
+        deleteAllItems(stakeHoldersTable);
     });
 });
diff --git a/cypress/e2e/views/applicationinventory.view.ts b/cypress/e2e/views/applicationinventory.view.ts
@@ -44,7 +44,7 @@ export const topKebabMenu = "#toolbar-kebab";
 export const kebabMenuItem = "span.pf-v5-c-menu__item-text";
 export const bulkApplicationSelectionCheckBox = "input[name='bulk-selected-items-checkbox']";
 // This is on the Application imports page.
-export const sideKebabMenuImports = "button[aria-label='Kebab toggle']";
+export const sideKebabMenu = "button[aria-label='Kebab toggle']";
 
 //Fields related to analysis - source mode
 export const sourceRepository = "input[name=sourceRepository]";