Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Draft]changing the test so it gets to the delete&edit buttns #1237

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Draft]changing the test so it gets to the delete&edit buttns #1237

wants to merge 2 commits into from
+17 −14

Conversation

TalyaNaima
Copy link

@TalyaNaima TalyaNaima commented Oct 8, 2024 •
edited by mguetta1
Loading

changing the tag&tagCategory cruds so that they get the edit&delete buttons

Should be merged after: konveyor/tackle2-ui#2119

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 8, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 8, 2024

Hi @TalyaNaima. Thanks for your PR.

I'm waiting for a konveyor member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mguetta1 mguetta1 self-requested a review October 8, 2024 12:06
@mguetta1
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 10, 2024
mguetta1
mguetta1 requested changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@mguetta1 mguetta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TalyaNaima, thanks for the PR!
I left few comments. In addition, please fix code formatting according the steps here

cypress/e2e/models/migration/controls/tagcategory.ts Outdated Show resolved Hide resolved
changing the test so it gets to the delete&edit buttns
1a86025 
Signed-off-by: TalyaNaima <Ttalya.brajtman@gmail.com>
@TalyaNaima TalyaNaima force-pushed the tags-edit&delete-test branch from 4557823 to 1a86025 Compare October 15, 2024 07:22
@sshveta
Copy link
Collaborator

sshveta commented Oct 15, 2024

Please run "nom run format" to format code .

@nachandr
Copy link
Contributor

Hi @TalyaNaima , Could you please run the relevant tests that use the updated methods on Jenkins and attach the results from the Jenkins run ?

@TalyaNaima TalyaNaima mentioned this pull request Oct 27, 2024
Open
@TalyaNaima
Copy link
Author

TalyaNaima commented Oct 28, 2024 via email

Fix format
f4f34bf 
Signed-off-by: TalyaNaima <Ttalya.brajtman@gmail.com>
@TalyaNaima TalyaNaima requested a review from mguetta1 October 31, 2024 10:56
mguetta1
mguetta1 approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@mguetta1 mguetta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@sshveta sshveta changed the title changing the test so it gets to the delete&edit buttns [Draft]changing the test so it gets to the delete&edit buttns Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mguetta1 mguetta1 mguetta1 approved these changes

Assignees
No one assigned
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TalyaNaima @mguetta1 @sshveta @nachandr