Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the way dc tests are tagged as they don't run properly with cy… #1263

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Change the way dc tests are tagged as they don't run properly with cy… #1263

merged 1 commit into from
Nov 14, 2024

Conversation

msajidmansoori12
Copy link
Contributor

…press_include_tags option

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 12, 2024

Hi @msajidmansoori12. Thanks for your PR.

I'm waiting for a konveyor member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 12, 2024
@msajidmansoori12 msajidmansoori12 force-pushed the test-tagging branch 2 times, most recently from 5ba5e3d to ec750db Compare November 12, 2024 07:41
kpunwatk
kpunwatk approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@kpunwatk kpunwatk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpunwatk
Copy link
Collaborator

@msajidmansoori12 Could you please check code formatting, npm run format

@msajidmansoori12
Change the way dc tests are tagged as they don't run properly with cy…
2b3b813 
…press_include_tags option

Signed-off-by: M Sajid Mansoori <mmansoor@redhat.com>
@msajidmansoori12
Copy link
Contributor Author

@kpunwatk , ran the formatting , can you please check.

@kpunwatk
Copy link
Collaborator

Approved, Thanks!

@abrugaro abrugaro merged commit 994b9d2 into konveyor:main Nov 14, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpunwatk kpunwatk kpunwatk approved these changes

@sshveta sshveta sshveta approved these changes

Assignees
No one assigned
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@msajidmansoori12 @kpunwatk @sshveta @abrugaro