[RFR] adapted upstream reports filter test #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adapted methods in reports.ts Signed-off-by: Neilhamza <nhamza@redhat.com>
ibragins
requested changes
Aug 15, 2023
sshveta
requested changes
Aug 15, 2023
sshveta
changed the title
Signed-off-by: Neilhamza <nhamza@redhat.com>
Neilhamza
changed the title
Signed-off-by: Neilhamza <nhamza@redhat.com>
Signed-off-by: Neilhamza <nhamza@redhat.com>
Signed-off-by: Neilhamza <nhamza@redhat.com>
sshveta
requested changes
Aug 22, 2023
Signed-off-by: Neilhamza <nhamza@redhat.com>
Signed-off-by: Neilhamza <nhamza@redhat.com>
abrugaro
requested changes
Aug 24, 2023
| .closest(articleCard) | ||
| .find(articleHeader) | ||
| .within(() => { | ||
| cy.get("button").click(); |
There was a problem hiding this comment.
You can use the button constant we have as you're already doing in line 44
There was a problem hiding this comment.
changed line 44 to "articleButton" instead of button and line 69 to button from constants to avoid confusion (they are not the same constant)
Signed-off-by: Neilhamza <nhamza@redhat.com>
abrugaro
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adapted methods in reports.ts
https://main-jenkins-csb-migrationqe.apps.ocp-c1.prod.psi.redhat.com/view/MTA/job/mta/job/tackle-ui-tests-on-ocp/450/