-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFR] added missing import in reports.ts #694
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neilhamza <nhamza@redhat.com>
Neilhamza
changed the title
[RFR] added missing import in reports.ts
[WIP] added missing import in reports.ts
Aug 27, 2023
Neilhamza
changed the title
[WIP] added missing import in reports.ts
[RFR] added missing import in reports.ts
Aug 28, 2023
abrugaro
requested changes
Aug 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor changes:
Line 30: selectItemsPerPageInReports
Line 50: riskType: string,
Signed-off-by: Neilhamza <nhamza@redhat.com>
Neilhamza
changed the title
[RFR] added missing import in reports.ts
[WIP] added missing import in reports.ts
Aug 28, 2023
Signed-off-by: Neilhamza <nhamza@redhat.com>
abrugaro
reviewed
Aug 28, 2023
cypress/e2e/models/migration/applicationinventory/assessment.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Neilhamza <nhamza@redhat.com>
Neilhamza
changed the title
[WIP] added missing import in reports.ts
[RFR] added missing import in reports.ts
Aug 29, 2023
abrugaro
approved these changes
Aug 29, 2023
ibragins
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a missing import
jenkins failed due to ongoing development of Assess in application inventory
https://main-jenkins-csb-migrationqe.apps.ocp-c1.prod.psi.redhat.com/view/MTA/job/mta/job/tackle-ui-tests-on-ocp/474/