Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] added missing import in reports.ts #694

Merged
merged 4 commits into from
Aug 29, 2023

Conversation

Neilhamza
Copy link
Collaborator

@Neilhamza Neilhamza commented Aug 27, 2023

added a missing import
jenkins failed due to ongoing development of Assess in application inventory
https://main-jenkins-csb-migrationqe.apps.ocp-c1.prod.psi.redhat.com/view/MTA/job/mta/job/tackle-ui-tests-on-ocp/474/
image

Signed-off-by: Neilhamza <nhamza@redhat.com>
@Neilhamza Neilhamza requested review from sshveta and abrugaro August 27, 2023 06:35
@Neilhamza Neilhamza changed the title [RFR] added missing import in reports.ts [WIP] added missing import in reports.ts Aug 27, 2023
@Neilhamza Neilhamza changed the title [WIP] added missing import in reports.ts [RFR] added missing import in reports.ts Aug 28, 2023
Copy link
Collaborator

@abrugaro abrugaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor changes:

Line 30: selectItemsPerPageInReports

Line 50: riskType: string,

Signed-off-by: Neilhamza <nhamza@redhat.com>
@Neilhamza Neilhamza requested a review from abrugaro August 28, 2023 10:44
@Neilhamza Neilhamza changed the title [RFR] added missing import in reports.ts [WIP] added missing import in reports.ts Aug 28, 2023
Signed-off-by: Neilhamza <nhamza@redhat.com>
Signed-off-by: Neilhamza <nhamza@redhat.com>
@Neilhamza Neilhamza requested a review from abrugaro August 28, 2023 12:56
@Neilhamza Neilhamza changed the title [WIP] added missing import in reports.ts [RFR] added missing import in reports.ts Aug 29, 2023
@Neilhamza Neilhamza requested review from sshveta and removed request for sshveta August 29, 2023 10:16
Copy link
Collaborator

@ibragins ibragins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abrugaro abrugaro merged commit da4cb01 into konveyor:main Aug 29, 2023
@Neilhamza Neilhamza deleted the upstream-import branch August 30, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants