[RFR] [JF] Refactored RBAC tests to adopt UI changes #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrugaro
requested changes
Nov 20, 2023
sshveta
reviewed
Nov 20, 2023
|
|
||
| const stakeholdersList: Array<Stakeholders> = []; | ||
| const stakeholdersNameList: Array<string> = []; | ||
| const fileName = "Legacy Pathfinder"; |
There was a problem hiding this comment.
There is a const called Legacy pathinder
abrugaro
approved these changes
Nov 20, 2023
sshveta
reviewed
Nov 20, 2023
| //Migrator is not allowed to review applications | ||
| application.validateReviewButton(this.rbacRules); | ||
| }); | ||
|
|
||
| it("Migrator, validate presence of import and manage imports", function () { |
There was a problem hiding this comment.
change the test name as well to cover all buttons.
Signed-off-by: Igor Braginsky <ibragins@redhat.com>
Signed-off-by: Igor Braginsky <ibragins@redhat.com>
sshveta
requested changes
Nov 20, 2023
|
|
||
| const stakeholdersList: Array<Stakeholders> = []; | ||
| const stakeholdersNameList: Array<string> = []; | ||
| const fileName = "Legacy Pathfinder"; |
There was a problem hiding this comment.
use const Legacy Pathfinder
| @@ -35,9 +42,20 @@ describe(["@tier2", "@rhsso"], "Architect RBAC operations", function () { | |||
|
|
|||
| before("Creating RBAC users, adding roles for them", function () { | |||
| login(); | |||
| AssessmentQuestionnaire.enable(fileName); | |||
| // Navigate to stakeholders control tab and create new stakeholder | |||
There was a problem hiding this comment.
This comment is not needed.
Signed-off-by: Igor Braginsky <ibragins@redhat.com>
sshveta
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.