Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Check 'Total Effort' instead of 'Effort' #970

Merged
merged 1 commit into from
Mar 11, 2024
Merged

[RFR] Check 'Total Effort' instead of 'Effort' #970

merged 1 commit into from
Mar 11, 2024

Conversation

mguetta1
Copy link
Contributor

ibragins
ibragins requested changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@ibragins ibragins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but formatting check is failing. Can you please fix that?

@mguetta1
Check 'Total Effort' instead of 'Effort'
a7e0bd9 
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
@mguetta1
Copy link
Contributor Author

LGTM, but formatting check is failing. Can you please fix that?

Thanks! fixed.

ibragins
ibragins approved these changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@ibragins ibragins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mguetta1 mguetta1 marked this pull request as draft February 19, 2024 12:23
@mguetta1
Copy link
Contributor Author

PR will be ready for merge once konveyor/tackle2-ui#1687 will be included in d/s build

kpunwatk
kpunwatk approved these changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@kpunwatk kpunwatk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@sshveta
Copy link
Collaborator

sshveta commented Feb 20, 2024

Move the PR to RFR once ready.

@mguetta1 mguetta1 marked this pull request as ready for review March 11, 2024 19:53
@mguetta1 mguetta1 changed the title Check 'Total Effort' instead of 'Effort' [RFR] Check 'Total Effort' instead of 'Effort' Mar 11, 2024
@mguetta1 mguetta1 merged commit cae4a8d into konveyor:main Mar 11, 2024
6 of 7 checks passed
@mguetta1 mguetta1 deleted the total-effort-column branch March 11, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshveta sshveta sshveta approved these changes

@ibragins ibragins ibragins approved these changes

@kpunwatk kpunwatk kpunwatk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mguetta1 @sshveta @ibragins @kpunwatk