🐛 Discontinue injecting labels. #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jortel
force-pushed
the
exclude-wildcard-labels
branch
from
5fbd560 to
58cb6ec
Compare
Signed-off-by: Jeff Ortel <jortel@redhat.com>
jortel
force-pushed
the
exclude-wildcard-labels
branch
from
58cb6ec to
ff7a16d
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each ruleset dependency (ruleset), the addon inspects the rules for labels and adds them to the selector. Some of the rules have wildcard source and target labels which must not be included in the selector.
The solution is to update seeded (dependency) rulesets to have:
This removes the
discoveryand other special labels that are not useful when used in konveyor.The tackle2-seed will need to be updated.
unrelated, I noticed while testing that Label methods needed a patch.