🐛 Update tackle2-hub dependency #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansam
approved these changes
Nov 10, 2023
Signed-off-by: Dylan Murray <dymurray@redhat.com>
|
@shawn-hurley this PR actually has no bearing on the failing tests. This PR should help get konveyor/go-konveyor-tests#53 passing. This directly fixes an issue we are seeing around missing codesnips. |
|
If I'm understanding then do you want me to button merge this? |
|
Noting here that I am purposefully merging this to unblock the test update, which should help fix the failing tests. If we see oddness around marshal/unmarshal, we should come here to look. |
This was referenced Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the tackle2-hub dependency which fixes yaml/json encoding of the reports.