🐛 Report command path without arguments and stdout/stderr on error. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Ortel <jortel@redhat.com>
dymurray
approved these changes
Nov 22, 2023
dymurray
pushed a commit
to dymurray/tackle2-addon
that referenced
this pull request
Nov 22, 2023
…onveyor#46) Update RunSilent() to not fail silently. Currently the returned error is reported as "exit code: 1" which isn't useful for troubleshooting. The primary goal for RunSilent() is to quietly run the command. One purpose is to prevent reporting arguments that contain credentials. This approach assumes that command don't output passwords to _stderr_. Example: ``` errors: - severity: Error description: exit status 1 - severity: Error description: 'Pod failed: Error' activity: - Fetching application. - '[CMD] Running: /usr/bin/ssh-agent -a /tmp/agent.736692' - '[CMD] succeeded.' - '[SSH] Agent started.' - '[MVN] Using settings file(path=/home/jortel/tmp/addon/settings.xml).' - '[SVN] Cloning: http://3.19.255.219/repos/trunk' - '[SVN] Using credentials (id=3) SVN.' - '[CMD] /usr/bin/svn failed: exit status 1.' - '> svn: warning: W170000: URL ''http://3.19.255.219/repos/trunk'' non-existent in revision 3' - '> ' - '> svn: E200009: Could not display info for all targets because some targets don''t exist' - '> ' ``` Signed-off-by: Jeff Ortel <jortel@redhat.com> (cherry picked from commit 31d1afa)
dymurray
pushed a commit
to dymurray/tackle2-addon
that referenced
this pull request
Nov 22, 2023
…onveyor#46) Update RunSilent() to not fail silently. Currently the returned error is reported as "exit code: 1" which isn't useful for troubleshooting. The primary goal for RunSilent() is to quietly run the command. One purpose is to prevent reporting arguments that contain credentials. This approach assumes that command don't output passwords to _stderr_. Example: ``` errors: - severity: Error description: exit status 1 - severity: Error description: 'Pod failed: Error' activity: - Fetching application. - '[CMD] Running: /usr/bin/ssh-agent -a /tmp/agent.736692' - '[CMD] succeeded.' - '[SSH] Agent started.' - '[MVN] Using settings file(path=/home/jortel/tmp/addon/settings.xml).' - '[SVN] Cloning: http://3.19.255.219/repos/trunk' - '[SVN] Using credentials (id=3) SVN.' - '[CMD] /usr/bin/svn failed: exit status 1.' - '> svn: warning: W170000: URL ''http://3.19.255.219/repos/trunk'' non-existent in revision 3' - '> ' - '> svn: E200009: Could not display info for all targets because some targets don''t exist' - '> ' ``` Signed-off-by: Jeff Ortel <jortel@redhat.com> (cherry picked from commit 31d1afa)
This was referenced Dec 11, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update RunSilent() to not fail silently. Currently the returned error is reported as "exit code: 1" which isn't useful for troubleshooting.
The primary goal for RunSilent() is to quietly run the command. One purpose is to prevent reporting arguments that contain credentials. This approach assumes that command don't output passwords to stderr.
Example: