-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Command verbosity with task report files. #50
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Closed
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
mansam
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Jeff Ortel <jortel@redhat.com>
jortel
added a commit
to konveyor/tackle2-addon-analyzer
that referenced
this pull request
Dec 19, 2023
Add support for verbosity. This mainly applies to reporting in task activity. When requested, the command output is included (live) in the activity log. This provides more detail and better insight into what the command is doing _currently_. Requires: - konveyor/tackle2-hub#577 - konveyor/tackle2-addon#50 --------- Signed-off-by: Jeff Ortel <jortel@redhat.com>
This was referenced Dec 21, 2023
Merged
jortel
added a commit
that referenced
this pull request
Jan 8, 2024
Fix regression introduced in #50 Signed-off-by: Jeff Ortel <jortel@redhat.com>
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add command reporting verbosity. This is intended to better support troubleshooting.
Mainly, the support for level=LiveOutput. This streams command output to files attached to the task report.
The output reporting is rate-limited using a backoff algorithm.
Add command
New
constructor and update the repository package to use it.Requires: konveyor/tackle2-hub#577
Example: