Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Command verbosity with task report files. #50

Merged
merged 12 commits into from
Dec 19, 2023

Conversation

jortel
Copy link
Contributor

@jortel jortel commented Dec 13, 2023

Add command reporting verbosity. This is intended to better support troubleshooting.
Mainly, the support for level=LiveOutput. This streams command output to files attached to the task report.

The output reporting is rate-limited using a backoff algorithm.

Add command New constructor and update the repository package to use it.

Requires: konveyor/tackle2-hub#577

Example:

 - '[CMD] Running: /usr/bin/konveyor-analyzer --provider-settings /addon/opt/settings.json --output-file /addon/report.yaml --no-dependency-rules --rules /addon/rules/rulesets/1/rules --rules /addon/rules/rulesets/24/rules --rules /addon/rules/rulesets/20/rules --label-selector konveyor.io/target=cloud-readiness --dep-label-selector !konveyor.io/dep-source=open-source'
    - '[CMD] /usr/bin/konveyor-analyzer succeeded.'
    - '[CMD] Running: /usr/bin/konveyor-analyzer-dep --provider-settings /addon/opt/settings.json --output-file /addon/deps.yaml'
    - '[CMD] /usr/bin/konveyor-analyzer-dep succeeded.'
    - 'Analysis reported. duration: 102.5784ms'
    - '[TAG] Tagging Application 4.'
    - Facts updated.
    - Done.
attached:
    - id: 989
      name: konveyor-analyzer.output
      activity: 44
    - id: 991
      name: konveyor-analyzer-dep.output
      activity: 50

Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
@jortel jortel mentioned this pull request Dec 13, 2023
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
@jortel jortel marked this pull request as ready for review December 15, 2023 16:30
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Copy link
Contributor

@mansam mansam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Jeff Ortel <jortel@redhat.com>
@jortel jortel merged commit 1119ca4 into konveyor:main Dec 19, 2023
2 checks passed
jortel added a commit to konveyor/tackle2-addon-analyzer that referenced this pull request Dec 19, 2023
Add support for verbosity. This mainly applies to reporting in task
activity.

When requested, the command output is included (live) in the activity
log. This provides more detail and better insight into what the command
is doing _currently_.

Requires:
- konveyor/tackle2-hub#577
- konveyor/tackle2-addon#50

---------

Signed-off-by: Jeff Ortel <jortel@redhat.com>
@jortel jortel mentioned this pull request Jan 8, 2024
jortel added a commit that referenced this pull request Jan 8, 2024
Fix regression introduced in #50

Signed-off-by: Jeff Ortel <jortel@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants