Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Add support for insecure SVN repos #52

Merged
merged 4 commits into from
Jan 10, 2024
Merged

Conversation

dymurray
Copy link
Contributor

@dymurray dymurray commented Jan 9, 2024

Signed-off-by: Dylan Murray dymurray@redhat.com

Signed-off-by: Dylan Murray <dymurray@redhat.com>
(cherry picked from commit 708b02e5a8c2e724cadc0c6687187c9d33be452e)
jortel

This comment was marked as outdated.

@jortel jortel dismissed their stale review January 10, 2024 14:58

Should refit maven and git.

Copy link
Contributor

@jortel jortel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency it would be good to (also) refit git and maven to use Remote.Insecure instead of getting separately.
Let's merge this for now so we don't delay getting svn fixed.

Signed-off-by: Dylan Murray <dymurray@redhat.com>
Signed-off-by: Dylan Murray <dymurray@redhat.com>
Signed-off-by: Dylan Murray <dymurray@redhat.com>
Copy link
Contributor

@jortel jortel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants