Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix casing in yaml field tags for API resources #527

Closed
mansam opened this issue Oct 17, 2023 · 0 comments · Fixed by #535
Closed

Fix casing in yaml field tags for API resources #527

mansam opened this issue Oct 17, 2023 · 0 comments · Fixed by #535
Assignees

Comments

@mansam
Copy link
Collaborator

mansam commented Oct 17, 2023

The YAML encoder/decoder expects field names to be all-lowercase by default, unlike the JSON encoder/decoder which preserves camelCasing. Because we have strict decoding enabled, this causes failures when camelCased fields are submitted as part of a YAML API request-- the YAML decoder does not recognize them as matching the names of the Go struct's fields. To fix this, we need to explicitly set yaml field tags on the Go structs with the proper casing.

@mansam mansam self-assigned this Oct 17, 2023
mansam added a commit that referenced this issue Oct 24, 2023
Fixes #527

Signed-off-by: Sam Lucidi <slucidi@redhat.com>
aufi pushed a commit to aufi/tackle2-hub that referenced this issue Oct 30, 2023
Fixes konveyor#527

Signed-off-by: Sam Lucidi <slucidi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant