Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👻 Skip Pathfinder calls when disconnected #271

Merged
merged 3 commits into from
Mar 23, 2023

Conversation

aufi
Copy link
Member

@aufi aufi commented Mar 22, 2023

Updating application delete action that calls Pathfinder API to not do that when running as Disconnected (e.g. for fast API tests).

Otherwise gets $ curl -X DELETE http://localhost:8080/applications/1 {"error":"Delete \"/pathfinder/assessments/bulkDelete\": unsupported protocol scheme \"\""}

Follow-up on #242

Signed-off-by: Marek Aufart <maufart@redhat.com>
@aufi aufi changed the title Skip Pathfinder calls when disconnected 👻 Skip Pathfinder calls when disconnected Mar 22, 2023
@aufi aufi requested a review from jortel March 22, 2023 13:48
Copy link
Contributor

@jortel jortel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's deal with this in pathfinder.go DeleteAssessment().

//
// DeleteAssessment deletes associated assessments by application Ids.
func (r *Pathfinder) DeleteAssessment(ids []uint, ctx *gin.Context) (err error) {
if Settings.Disconnected {
  return
}

aufi added 2 commits March 23, 2023 10:28
Signed-off-by: Marek Aufart <maufart@redhat.com>
Signed-off-by: Marek Aufart <maufart@redhat.com>
@aufi
Copy link
Member Author

aufi commented Mar 23, 2023

Let's deal with this in pathfinder.go DeleteAssessment().

Good point, updated, thanks!

@aufi aufi requested a review from jortel March 23, 2023 09:30
Copy link
Contributor

@jortel jortel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aufi aufi merged commit b7c113e into konveyor:main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants