✨ Add dependency relationship to RuleSets #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Lucidi <slucidi@redhat.com>
mansam
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jortel
reviewed
Jun 29, 2023
migration/v6/model/ruleset.go
Outdated
| type RuleSetDependency struct { | ||
| RuleSetID uint `gorm:"primaryKey"` | ||
| DependsOnID uint `gorm:"primaryKey"` | ||
| } |
There was a problem hiding this comment.
Seems like it would be good to avoid defining the RuleSetDependency model. curious about why query that table instead of the RuleSet?
Re: BeforeUpdate() - How is Create protected?
Signed-off-by: Sam Lucidi <slucidi@redhat.com>
mansam
force-pushed
the
ruleset-dependencies
branch
from
86cdadf
to
eac7781
Compare
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.