🐛 Only create connector once to fix ident mangling #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansam
changed the title
Signed-off-by: Sam Lucidi <slucidi@redhat.com>
mansam
force-pushed
the
fix-jira-identity-mangling
branch
from
5e3d457
to
76226d9
Compare
mansam
added a commit
that referenced
this pull request
Jul 25, 2023
Backport of #460 Signed-off-by: Sam Lucidi <slucidi@redhat.com>
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating the tracker connector inside of the loop results in Decrypt being called on the tracker's Identity once for each ticket to be created. Decrypt is not idempotent, so this scrambles the password on subsequent calls. This was causing batch creation of Jira tickets to fail strangely, as only the first ticket in any batch would be created before the credentials were scrambled.
Fixes https://issues.redhat.com/projects/MTA/issues/MTA-696