Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix analyses RBAC. #472

Merged
merged 2 commits into from
Aug 10, 2023
Merged

🐛 Fix analyses RBAC. #472

merged 2 commits into from
Aug 10, 2023

Conversation

jortel
Copy link
Contributor

@jortel jortel commented Aug 10, 2023 •
edited
Loading

Fix RBAC for:

  • /analyses - This is the primary endpoint for analyses
  • /applications/:id/analyses endpoints - This is the analyses subresource under applications.

Roles:

  • Addon: CRUD for:
    • /applications/:id/analyses
  • Admin, Architect: CRUD for:
    • /analyses
    • /applications/:id/analyses
  • Migrator, Project-Manager: Read-Only,
    • /analyses
    • /applications/:id/analyses

@jortel
🐛 Fix analyses RBAC.
9ad8637 
Signed-off-by: Jeff Ortel <jortel@redhat.com>
@jortel
Moved route comment.
5211b30 
Signed-off-by: Jeff Ortel <jortel@redhat.com>
dymurray
dymurray approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@dymurray dymurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jortel jortel merged commit f18f21c into konveyor:main Aug 10, 2023
This was referenced Nov 22, 2023
Merged
Merged
This was referenced Jan 23, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dymurray dymurray dymurray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jortel @dymurray