Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Protect builtin questionnaires from update/delete #512

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

mansam
Copy link
Collaborator

@mansam mansam commented Oct 10, 2023

Only changing the required field is permitted for builtin questionnaires, all other changes and deletion are disallowed.

@mansam mansam requested a review from jortel October 10, 2023 15:08
@ibolton336
Copy link
Member

Screenshot 2023-10-10 at 11 46 23 AM

Tested and looks great.

@mansam mansam changed the title Protect builtin questionnaires from update/delete 🐛 Protect builtin questionnaires from update/delete Oct 10, 2023
Signed-off-by: Sam Lucidi <slucidi@redhat.com>
Signed-off-by: Sam Lucidi <slucidi@redhat.com>
@mansam mansam force-pushed the protect-builtin-questionnaires branch from 43f31bd to 9aba561 Compare October 10, 2023 16:27
@mansam mansam merged commit 27a44ea into konveyor:main Oct 10, 2023
9 checks passed
aufi pushed a commit to aufi/tackle2-hub that referenced this pull request Oct 30, 2023
Only changing the `required` field is permitted for builtin
questionnaires, all other changes and deletion are disallowed.

---------

Signed-off-by: Sam Lucidi <slucidi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants