Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Improve Jira error handling #574

Merged
merged 1 commit into from
Dec 12, 2023
Merged

🐛 Improve Jira error handling #574

merged 1 commit into from
Dec 12, 2023

Conversation

mansam
Copy link
Collaborator

@mansam mansam commented Dec 6, 2023 •
edited
Loading

  • Wrap the http.Client used by the Jira library to always add an Accept: application/json header to requests. This fixes the XML and HTML responses from some endpoints during error conditions.
  • Directly use jiraclient.Do method instead of convenience methods to work around library-provided error handling that doesn't work in all cases. This gets rid of vague "inspect response body" errors for failure responses not handled by the library.
  • Do our own error handling that catches the response format returned by the /myself endpoint and others.

@mansam
Improve Jira error handling
fc4a7de 
* Wrap the http.Client used by the Jira library
  to always add an Accept: application/json header
  to requests. This fixes the XML and HTML responses
  from some endpoints during error conditions.
* Directly use jiraclient.Do method instead of convenience
  methods to work around library-provided error handling
  that doesn't work in all cases.

Signed-off-by: Sam Lucidi <slucidi@redhat.com>
@mansam mansam requested a review from jortel December 6, 2023 18:43
jortel
jortel approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@jortel jortel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mansam mansam merged commit 64df283 into konveyor:main Dec 12, 2023
12 of 13 checks passed
This was referenced Dec 16, 2023
Merged
Merged
This was referenced Jan 23, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jortel jortel jortel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mansam @jortel