update tests

Signed-off-by: ibolton336 <ibolton@redhat.com>
konveyor · Nov 8, 2023 · 23c1786 · 23c1786
1 parent 8a4e764
commit 23c1786
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/client/src/app/pages/assessment/form-utils.test.ts b/client/src/app/pages/assessment/form-utils.test.ts
@@ -30,11 +30,11 @@ describe("Application assessment - form utils", () => {
 
   it("getQuestionFieldName: fullName", () => {
     const fieldName = getQuestionFieldName(question, true);
-    expect(fieldName).toBe("questions.question-1-Question_321");
+    expect(fieldName).toBe("questions.section-1-question-1-Question_321");
   });
 
   it("getQuestionFieldName: singleName", () => {
     const fieldName = getQuestionFieldName(question, false);
-    expect(fieldName).toBe("question-1-Question_321");
+    expect(fieldName).toBe("section-1-question-1-Question_321");
   });
 });
diff --git a/client/src/app/queries/assessments.ts b/client/src/app/queries/assessments.ts
@@ -1,4 +1,5 @@
 import { useMutation, useQuery, useQueryClient } from "@tanstack/react-query";
+import { useMemo } from "react";
 
 import {
   createAssessment,
@@ -27,8 +28,10 @@ export const useFetchAssessments = () => {
     queryFn: getAssessments,
     onError: (error: AxiosError) => console.log("error, ", error),
   });
-  const assessmentsWithOrder: AssessmentWithSectionOrder[] =
-    data?.map(addSectionOrderToQuestions) || [];
+  const assessmentsWithOrder: AssessmentWithSectionOrder[] = useMemo(
+    () => data?.map(addSectionOrderToQuestions) || [],
+    [data]
+  );
 
   return {
     assessments: assessmentsWithOrder || [],