Skip to content

Commit

Permalink
🌱 Downgrade to rollup v3 for multiarch builds (#1742)
Browse files Browse the repository at this point in the history
Following up on PRs #1664 and #1739, downgrade to `rollup@^3.0`. The v4
of rollup has "native" code that runs the build, and that code does not
currently work with s390 builds [1]. Since konveyor is built for x86,
arm, ppc, and s390, all of those need to work.

When the s390 builds can work with the wasm bits, we can upgrade to
`rollup@^4.0` again.

[1] - rollup/rollup#5354

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
  • Loading branch information
sjd78 authored Mar 5, 2024
1 parent 6bbca51 commit ddcbccf
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 225 deletions.
229 changes: 5 additions & 224 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@
"@rollup/plugin-run": "^3.0.2",
"@rollup/plugin-typescript": "^11.1.6",
"@rollup/plugin-virtual": "^3.0.2",
"@rollup/wasm-node": "^4.12.0",
"@tanstack/eslint-plugin-query": "^4.34.1",
"@types/jest": "^29.5.4",
"@types/node": "^18.14.2",
Expand All @@ -67,6 +66,7 @@
"lint-staged": "^14.0.1",
"prettier": "^3.0.2",
"rimraf": "^4.4.1",
"rollup": "^3.29.4",
"rollup-plugin-copy": "^3.5.0",
"ts-jest": "^29.1.1",
"ts-node": "^10.9.1",
Expand Down

0 comments on commit ddcbccf

Please sign in to comment.