Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facts tab shows when no facts are present in the app drawer #1100

Closed
ibolton336 opened this issue Jul 7, 2023 · 0 comments · Fixed by #1103
Closed

Facts tab shows when no facts are present in the app drawer #1100

ibolton336 opened this issue Jul 7, 2023 · 0 comments · Fixed by #1103
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@ibolton336
Copy link
Member

No description provided.

@ibolton336 ibolton336 added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Jul 7, 2023
@ibolton336 ibolton336 added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Jul 7, 2023
@ibolton336 ibolton336 mentioned this issue Jul 10, 2023
Merged
ibolton336 added a commit that referenced this issue Jul 12, 2023
@ibolton336
🐛 Always show analysis details in drawer (#1103)
aedaf9c 
- It was reported (no bz) that the analysis details should always be
accessible from the side drawer. This PR removes the spinner for
in-progress analysis status & replaces it with a link to the code viewer
modal. Resolves #1013
- Also, this PR hides the facts tab when no facts are present. Resolves
#1100

Signed-off-by: ibolton336 <ibolton@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
No open projects
Konveyor UI
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Always show analysis details in drawer ibolton336/tackle2-ui
1 participant
@ibolton336