Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View assessments page for existing assessments #1301

Closed
ibolton336 opened this issue Aug 22, 2023 · 0 comments
Closed

View assessments page for existing assessments #1301

ibolton336 opened this issue Aug 22, 2023 · 0 comments
Assignees
@ibolton336
Labels
Custom Assessment Items relating to custom assessment work

Comments

@ibolton336
Copy link
Member

Image

  • Add a way to view the previously taken assessments with the selected assessment values populated in a read-only mode.
@ibolton336 ibolton336 converted this from a draft issue Aug 22, 2023
@ibolton336 ibolton336 added the Custom Assessment Items relating to custom assessment work label Aug 22, 2023
This was referenced Aug 23, 2023
Closed
Merged
ibolton336 added a commit that referenced this issue Aug 24, 2023
@ibolton336
✨ Convert assessment table to new table & begin assessment flow chang…
c763fc3 
…es (#1294)

- Update questionnaire TS model to match hub proposal

```
type Questionnaire struct {
	Resource
	Name         string
	Description  string
	Revision     uint
	Required     bool
	Sections     []Section
	Thresholds   Thresholds
	RiskMessages RiskMessages
}

type Assessment struct {
	Resource
	Application   *Ref
	Archetype     *Ref
	Questionnaire *Ref
	Sections      []Section
}

```
- Convert assessment table to use new table format
- No longer allow bulk assessment on assessment page top level toolbar
as this functionality is moving to Archetypes. Review & assessment
buttons moved to dropdown kebabs on the row level.
- Assessment Actions page with application level
questionnaires/assessments listed. TODO: [Add dynamic actions
button](#1299) based on
current assessment status
- Adds placeholder assessment modal when assessment action is triggered
from the assessment table row. TODO: [Add existing archetype
check](#1298)
- TODO: [View assessments page for existing
assessments](#1301) for
viewing existing assessments when clicking assess on an application that
already has an associated completed assessment
- TODO: [Convert assessment wizard
](#1306)
-TODO: Fix empty state initial render
#1311

Signed-off-by: ibolton336 <ibolton@redhat.com>
ibolton336 added a commit to ibolton336/tackle2-ui that referenced this issue Aug 24, 2023
@ibolton336
✨ Convert assessment table to new table & begin assessment flow chang…
24883ae 
…es (konveyor#1294)

- Update questionnaire TS model to match hub proposal

```
type Questionnaire struct {
	Resource
	Name         string
	Description  string
	Revision     uint
	Required     bool
	Sections     []Section
	Thresholds   Thresholds
	RiskMessages RiskMessages
}

type Assessment struct {
	Resource
	Application   *Ref
	Archetype     *Ref
	Questionnaire *Ref
	Sections      []Section
}

```
- Convert assessment table to use new table format
- No longer allow bulk assessment on assessment page top level toolbar
as this functionality is moving to Archetypes. Review & assessment
buttons moved to dropdown kebabs on the row level.
- Assessment Actions page with application level
questionnaires/assessments listed. TODO: [Add dynamic actions
button](konveyor#1299) based on
current assessment status
- Adds placeholder assessment modal when assessment action is triggered
from the assessment table row. TODO: [Add existing archetype
check](konveyor#1298)
- TODO: [View assessments page for existing
assessments](konveyor#1301) for
viewing existing assessments when clicking assess on an application that
already has an associated completed assessment
- TODO: [Convert assessment wizard
](konveyor#1306)
-TODO: Fix empty state initial render
konveyor#1311

Signed-off-by: ibolton336 <ibolton@redhat.com>
@ibolton336 ibolton336 moved this from Todo to In Progress in Konveyor UI Aug 31, 2023
@ibolton336 ibolton336 self-assigned this Aug 31, 2023
@ibolton336 ibolton336 mentioned this issue Aug 31, 2023
Merged
ibolton336 added a commit that referenced this issue Sep 11, 2023
@ibolton336
✨ Dynamic assess button and view assessments page (#1325)
e3f1630 
Resolves #1299 #1301 #1300 
- Moves QuestionsTable and AnswersTable components to shared root
components directory
- Adds assessment summary page - this page is reached via the "View"
button on the assessment actions page. It shows the current assessment's
answers by using the shared "QuestionnaireSummary" component which is
also used by the questionnaire page referenced by
assessment-settings-page in the admin view. The QuestionnaireSummary
covers both cases with a conditional option for showing the answer key.
- Adds Dynamic assessment actions button for view/take/retake/continue
actions
- Adds delete assessment button and functionality. 
- Add table for archived questionnaires in assessment actions page

Note: Will need to uncomment these lines for testing
https://github.com/konveyor/tackle2-ui/pull/1325/files#diff-b0560fce9e9111641c87e7daa6648f4d60fd0b620522ff84501ec5dadd7f4128R38-R51

Signed-off-by: ibolton336 <ibolton@redhat.com>
@ibolton336 ibolton336 moved this from In Progress to Done in Konveyor UI Sep 12, 2023
@ibolton336 ibolton336 reopened this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibolton336 ibolton336

Labels
Custom Assessment Items relating to custom assessment work
Projects
No open projects
Konveyor UI
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ibolton336