Reports page api updates #1305
Assignees
Labels
Custom Assessment
Items relating to custom assessment work
Comments
sjd78
added a commit
that referenced
this issue
Sep 21, 2023
Shows selection of possible questionnaires of current assessments
Pass to `<Landscape>`:
- If "All questionnaires" option has been selected then the whole
assessments list is passed
- When a specific questionnaire is selected then only the assessments
bound to that questionnaire are passed.
The consolidation of the risks is left to be handled by the Landscape
component in following PR.
#1305
---------
Signed-off-by: Gilles Dubreuil <gdubreui@redhat.com>
Co-authored-by: Scott Dickerson <sdickers@redhat.com>
sjd78
added a commit
to sjd78/tackle2-ui
that referenced
this issue
Sep 22, 2023
Custom assessments changes risk and confidence to be accessed from
`Assessment` and not `Application`. The reports page in general, and
the `Landscape` component in specific need to be updated to use risk
values from `Assessment`.
Summary of Change:
- `Reports`
- Fetch `Questionnaires` and `Assessments` to allow easy use
in the Questionnaire select menu
- Adjust the `Card`s to be clickable and selectable when we provide
custom actions (to avoid a console warning)
- `Landscape`
- Use data from props instead of fetching any additional data. The
containing component is now responsible for controlling the
source data.
- Aggregate risk data into buckets matching `Risk` options
- Setup responsive layout so the donut charts wrap nicely when the
view becomes narrow
- `Donut`
- Force `id` to be provided
- Set the width to `200px`
- Make sure content lines up centered in its container
- Deprecated `useFetchRisks()`
Enhancement: https://github.com/konveyor/enhancements/blob/90b827b68cc367284a66bf66f087d5c263487e05/enhancements/assessment-module/README.md#changes-in-the-application-reports-view
Part Of: konveyor#1305
Follow Up: konveyor#1374
Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
sjd78
added a commit
to sjd78/tackle2-ui
that referenced
this issue
Sep 22, 2023
Custom assessments changes risk and confidence to be accessed from
`Assessment` and not `Application`. The reports page in general, and
the `Landscape` component in specific need to be updated to use risk
values from `Assessment`.
Summary of Change:
- `Reports`
- Fetch `Questionnaires` and `Assessments` to allow easy use
in the Questionnaire select menu
- Adjust the `Card`s to be clickable and selectable when we provide
custom actions (to avoid a console warning)
- `Landscape`
- Use data from props instead of fetching any additional data. The
containing component is now responsible for controlling the
source data.
- Aggregate risk data into buckets matching `Risk` options
- Setup responsive layout so the donut charts wrap nicely when the
view becomes narrow
- `Donut`
- Force `id` to be provided
- Set the width to `200px`
- Make sure content lines up centered in its container
- Deprecated `useFetchRisks()`
Enhancement: https://github.com/konveyor/enhancements/blob/90b827b68cc367284a66bf66f087d5c263487e05/enhancements/assessment-module/README.md#changes-in-the-application-reports-view
Part Of: konveyor#1305
Follow Up: konveyor#1374
Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
ibolton336
added a commit
that referenced
this issue
Sep 25, 2023
# Summary Custom assessments changes risk and confidence to be accessed from `Assessment` and not `Application`. The reports page in general, and the `Landscape` component in specific need to be updated to use risk values from `Assessment`. ## Changes `Reports` - Fetch `Questionnaires` and `Assessments` to allow easy use in the Questionnaire select menu - Adjust the `Card`s to be clickable and selectable when we provide custom actions (to avoid a console warning) `Landscape` - Use data from props instead of fetching any additional data. The containing component is now responsible for controlling the source data. - Aggregate risk data into buckets matching `Risk` options - Setup responsive layout so the donut charts wrap nicely when the view becomes narrow `Donut` - Force `id` to be provided - Set the width to `200px` - Make sure content lines up centered in its container Deprecated `useFetchRisks()` ## Screenshots All questionnaires:  Single questionnaire:  ## References Enhancement: https://github.com/konveyor/enhancements/blob/90b827b68cc367284a66bf66f087d5c263487e05/enhancements/assessment-module/README.md#changes-in-the-application-reports-view Part Of: #1305 Follow Up: #1374 Signed-off-by: Scott J Dickerson <sdickers@redhat.com> Co-authored-by: Ian Bolton <ibolton@redhat.com>
|
With the details on this issue a bit old now, and direction changing slightly in advance of the next set of changes, this issue can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The reports page needs to be driven by all available questionnaire data. There will also be a dropdown to select which archetype to drive the reports data from at the top of the page with the default being all existing questionnaires in the database with a "required" flag set to true
https://www.sketch.com/s/af50e991-8061-4b69-84c1-c11241e274f2/a/VEvWnDo
https://www.sketch.com/s/af50e991-8061-4b69-84c1-c11241e274f2/a/zyq8Y1M
To do:
riskMessagesfrom the questionnaire displayed as a sub-title, when a single questionnaire is selected: See See ✨ Reports - Current Landscape update risk handling #1395The text was updated successfully, but these errors were encountered: