Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Editing an application does not prefill existing tags in the form, so editing and saving removes all tags not added during the edit #1372

Closed
1 task done
mturley opened this issue Sep 18, 2023 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@mturley
Copy link
Collaborator

mturley commented Sep 18, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

main

Priority

Undefined (Default)

Current Behavior

Find an application in the app inventory page (both tabs) that has tags on it. Use the kebab menu to edit the application, which opens the "update application" modal with most fields prefilled. The tags field is empty. Editing something else in the form and clicking Save updates the application with an empty list of tags (removing the existing tags). Similarly, adding a tag to this field and saving results in the application only having the newly added tag and not the existing tags.

Expected Behavior

The tags field in the "update application" modal should be pre-filled with the tags that are already present on the application. Submitting the edits should not remove tags that were already present.

How Reproducible

Always (Default)

Steps To Reproduce

See above

Environment

- OS:

Anything else?

No response

@mturley mturley added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 18, 2023
@mturley mturley added this to Planning Sep 18, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Sep 18, 2023
@ibolton336 ibolton336 moved this from 🆕 New to 🔖 Ready in Planning Sep 28, 2023
@ibolton336 ibolton336 moved this from 🔖 Ready to ✅ Done in Planning Sep 28, 2023
@sjd78
Copy link
Member

sjd78 commented Oct 13, 2023

This was fixed over a series of PRs as the same problem was reported in multiple distinct ways:

@mturley , @ibolton336 - At this point, I think this PR can be closed as already fixed. If either of you think there is still a gap, feel free to reopen the issue.

@sjd78 sjd78 closed this as completed Oct 13, 2023
@mturley
Copy link
Collaborator Author

mturley commented Oct 13, 2023

Awesome, thanks for following up @sjd78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants