Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Missing assessment tags #1459

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

ibolton336
Copy link
Member

https://issues.redhat.com/browse/MTA-1381

  • Shows criteria tags in edit form
  • Fixes hard nav cleanup oversight. Only cancel assessment when not actively saving.

Split out assessment tags from manual archetype tags in drawer

Signed-off-by: ibolton336 <ibolton@redhat.com>
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9973f1b) 40.89% compared to head (6a7b6e8) 40.89%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1459   +/-   ##
=======================================
  Coverage   40.89%   40.89%           
=======================================
  Files         139      139           
  Lines        4450     4450           
  Branches     1017     1017           
=======================================
  Hits         1820     1820           
  Misses       2618     2618           
  Partials       12       12           
Flag Coverage Δ
client 40.89% <100.00%> (ø)
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/components/application-form/application-form.tsx 66.31% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ibolton336 ibolton336 merged commit cedcd28 into konveyor:main Oct 11, 2023
6 checks passed
@ibolton336
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant