A recent change to tackle2-hub breaks archetype functionality in UI #1436
Assignees
Labels
Custom Assessment
Items relating to custom assessment work
kind/bug
Categorizes issue or PR as related to a bug.
Milestone
Comments
sjd78
added
kind/bug
sjd78
removed
the
needs-triage
sjd78
changed the title
ibolton336
pushed a commit
that referenced
this issue
Oct 6, 2023
…1438) ### Summary Resolves: #1436 With hub updates to tag handling and api field name changes related to archetypes, adjustments needed to be made to the UI. ### Archetype model - Update `models.ts` to the current state of `TagRef` and `Archetype` in terms of field names and data types. - MSW stub data updated to use api model changes. ### Archetype Table - **Note**: The tags column on the archetype table is currently displaying ALL tags returned with no source differentiation. ### Archetype Add/EditForm - Update `ArchetypeForm` to use `criteria` instead of `criteriaTags` as per the api model changes. - With hub changes to combine the archetype and non-archetype tags into a single field, the form processing now ignored non-archetype fields but still sends them on an update. - Note: This change mirrors the behavior of manual / non-manual tags on applications and the application form. - Stakeholder and stakeholder groups handling is updated to use the `*ToRef()` helper function style introduced in the application form change #1408. ### Archetype Detail Drawer - Since all tags for an archetype are provided in the same field `tags`, filter them into "archetype tags" (i.e. an empty source) and "assessment tags" (i.e. have a non-empty source) to display them separately. - Note: The "archetype tags" are the tags manually attached to the archetype in the new/edit form. --------- Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there an existing issue for this?
Konveyor version
main
Priority
Critical
Current Behavior
A new Archetype cannot be created. Error shown is
json: unknown field "criteriaTags".In the archetype details drawer, an archetype's assessment tags are not displayed.
An archetype or application cannot be assessed.Fixed on hub: konveyor/tackle2-hub#506Expected Behavior
Archetype creation should work.
Assessing an archetype should work.
The tags from an archetype's assessments should be displayed in the detail drawer.
How Reproducible
Always (Default)
Steps To Reproduce
No response
Environment
No response
Anything else?
The tackle2-hub pull request with the rest api change: konveyor/tackle2-hub#502
The text was updated successfully, but these errors were encountered: