-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add refresh button to document viewer #1087
✨ Add refresh button to document viewer #1087
Conversation
c3664b3
to
5a456b1
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1087 +/- ##
=======================================
Coverage 46.91% 46.91%
=======================================
Files 177 177
Lines 4442 4442
Branches 1027 1027
=======================================
Hits 2084 2084
Misses 2285 2285
Partials 73 73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but the customerControls
array can be adjusted.
aria-label="code content type selection" | ||
className="language-toggle-group" | ||
<> | ||
{refreshControl} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
customControls
is an array of elements, so this can just be its own array element. No need to change the other controls.
The "code-language-toggle" should be last in the array.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated - nice catch.
Signed-off-by: ibolton336 <ibolton@redhat.com>
ee936a5
to
c04ac4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Adds a refresh button for the custom code editor. This will allow the refresh of analysis details without refreshing the browser or relying on polling.
Closes #1086