Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add refresh button to document viewer #1087

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

ibolton336
Copy link
Member

@ibolton336 ibolton336 commented Jul 3, 2023

Adds a refresh button for the custom code editor. This will allow the refresh of analysis details without refreshing the browser or relying on polling.
Screenshot 2023-07-03 at 4 27 42 PM

Closes #1086

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (54f156b) 46.91% compared to head (90144b3) 46.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1087   +/-   ##
=======================================
  Coverage   46.91%   46.91%           
=======================================
  Files         177      177           
  Lines        4442     4442           
  Branches     1027     1027           
=======================================
  Hits         2084     2084           
  Misses       2285     2285           
  Partials       73       73           
Flag Coverage Δ
unitests 46.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ibolton336 ibolton336 changed the title Feat: Add refresh button to document viewer ✨ Add refresh button to document viewer Jul 5, 2023
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but the customerControls array can be adjusted.

aria-label="code content type selection"
className="language-toggle-group"
<>
{refreshControl}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

customControls is an array of elements, so this can just be its own array element. No need to change the other controls.

The "code-language-toggle" should be last in the array.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated - nice catch.

Signed-off-by: ibolton336 <ibolton@redhat.com>
@ibolton336 ibolton336 requested a review from sjd78 July 5, 2023 16:27
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a refresh button to the analysis details modal
2 participants