Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Jira: Add URL filter and sorting #1088

Merged
merged 2 commits into from
Jul 10, 2023
Merged

✨ Jira: Add URL filter and sorting #1088

merged 2 commits into from
Jul 10, 2023

Conversation

gildub
Copy link
Contributor

@gildub gildub commented Jul 5, 2023

@gildub gildub self-assigned this Jul 5, 2023
@gildub gildub changed the title Jira: Add URL filter ✨ Jira: Add URL filter Jul 5, 2023
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7130f44) 46.70% compared to head (7686332) 46.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1088   +/-   ##
=======================================
  Coverage   46.70%   46.70%           
=======================================
  Files         177      177           
  Lines        4462     4462           
  Branches     1001     1001           
=======================================
  Hits         2084     2084           
  Misses       2364     2364           
  Partials       14       14           
Flag Coverage Δ
unitests 46.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sjd78
Copy link
Member

sjd78 commented Jul 5, 2023

@gildub, @ibolton336 - Does this actually solve MTA-908 that states "Incorrect sorting by URL for Jira instances"?

A quick look at the table component and I saw:

getSortValues: (tracker) => ({
name: tracker.name || "",
url: "", // TODO
}),

I'm assuming that TODO item is the cause of MTA-908.

@ibolton336
Copy link
Member

Ahh good catch @sjd78 - I tested that this filter was working but missed that the linked issue is actually dealing with sort.

Copy link
Member

@ibolton336 ibolton336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the sort support here too per @sjd78's suggestion?

@gildub
Copy link
Contributor Author

gildub commented Jul 5, 2023

@sjd78, yeah I missed that too. Thanks.

@gildub gildub requested a review from ibolton336 July 6, 2023 09:53
@sjd78 sjd78 changed the title ✨ Jira: Add URL filter ✨ Jira: Add URL filter and sorting Jul 6, 2023
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Gilles Dubreuil <gdubreui@redhat.com>
Signed-off-by: Gilles Dubreuil <gdubreui@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants