-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Jira: Add URL filter and sorting #1088
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1088 +/- ##
=======================================
Coverage 46.70% 46.70%
=======================================
Files 177 177
Lines 4462 4462
Branches 1001 1001
=======================================
Hits 2084 2084
Misses 2364 2364
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@gildub, @ibolton336 - Does this actually solve MTA-908 that states "Incorrect sorting by URL for Jira instances"? A quick look at the table component and I saw: tackle2-ui/client/src/app/pages/external/jira/trackers.tsx Lines 126 to 129 in 54f156b
I'm assuming that TODO item is the cause of MTA-908. |
Ahh good catch @sjd78 - I tested that this filter was working but missed that the linked issue is actually dealing with sort. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add the sort support here too per @sjd78's suggestion?
@sjd78, yeah I missed that too. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Gilles Dubreuil <gdubreui@redhat.com>
Signed-off-by: Gilles Dubreuil <gdubreui@redhat.com>
) Resolves https://issues.redhat.com/browse/MTA-908 (cherry picked from commit 573bce2)
Resolves https://issues.redhat.com/browse/MTA-908