Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Restore legacy select #1101

Merged
merged 1 commit into from
Jul 11, 2023
Merged

✨ Restore legacy select #1101

merged 1 commit into from
Jul 11, 2023

Conversation

gildub
Copy link
Contributor

@gildub gildub commented Jul 10, 2023

#1078 follow-up to restore personae select look and feel.

@gildub gildub changed the title :sparkes: Restore legacy select ✨ Restore legacy select Jul 10, 2023
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch coverage: 16.00% and project coverage change: -0.06 ⚠️

Comparison is base (4e31629) 44.10% compared to head (8df5543) 44.04%.

❗ Current head 8df5543 differs from pull request most recent head 26af1e0. Consider uploading reports for the commit 26af1e0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1101      +/-   ##
==========================================
- Coverage   44.10%   44.04%   -0.06%     
==========================================
  Files         177      177              
  Lines        4487     4493       +6     
  Branches     1001     1007       +6     
==========================================
  Hits         1979     1979              
- Misses       2497     2503       +6     
  Partials       11       11              
Flag Coverage Δ
unitests 44.04% <16.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/src/app/layout/SidebarApp/SidebarApp.tsx 26.66% <16.00%> (-2.97%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @gildub

Signed-off-by: Gilles Dubreuil <gdubreui@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants