Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Start notifications in upper case #1142

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Conversation

abrugaro
Copy link
Contributor

Signed-off-by: Alejandro Brugarolas <abrugaro@redhat.com>
@gildub
Copy link
Contributor

gildub commented Jul 17, 2023

Thank you @abrugaro !
Could you please rebase ?

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (379be74) 44.09% compared to head (006cd41) 44.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1142   +/-   ##
=======================================
  Coverage   44.09%   44.09%           
=======================================
  Files         177      177           
  Lines        4499     4499           
  Branches     1007     1007           
=======================================
  Hits         1984     1984           
  Misses       2504     2504           
  Partials       11       11           
Flag Coverage Δ
unitests 44.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gildub gildub merged commit ad148d5 into konveyor:main Jul 20, 2023
@abrugaro abrugaro deleted the mta-974 branch July 20, 2023 15:46
@ibolton336
Copy link
Member

Backport needed @abrugaro @gildub

ibolton336 pushed a commit to ibolton336/tackle2-ui that referenced this pull request Jul 21, 2023
Solves https://issues.redhat.com/browse/MTA-974
Co-authored-by: Mike Turley <mike.turley@alum.cs.umass.edu>
ibolton336 pushed a commit to ibolton336/tackle2-ui that referenced this pull request Jul 21, 2023
Solves https://issues.redhat.com/browse/MTA-974
Co-authored-by: Mike Turley <mike.turley@alum.cs.umass.edu>

Signed-off-by: ibolton336 <ibolton@redhat.com>
ibolton336 added a commit that referenced this pull request Jul 21, 2023
…1189)

Solves https://issues.redhat.com/browse/MTA-974
Co-authored-by: Mike Turley <mike.turley@alum.cs.umass.edu>

Signed-off-by: ibolton336 <ibolton@redhat.com>
Co-authored-by: Alejandro Brugarolas <117646518+abrugaro@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants