✨ Application tables: Refactor useEntityModal

[gildub]

Replace useEntityModal with in-file state.

See #1234 for details

Also:

• Add missing notification when managing applications credentials.
• Application-form: Replace Alert with Notification

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (9d59bd2) 44.03% compared to head (dbc138e) 44.02%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1235      +/-   ##
==========================================
- Coverage   44.03%   44.02%   -0.02%     
==========================================
  Files         177      177              
  Lines        4524     4516       -8     
  Branches     1009     1037      +28     
==========================================
- Hits         1992     1988       -4     
+ Misses       2521     2453      -68     
- Partials       11       75      +64     

Flag	Coverage Δ
client	44.02% <0.00%> (-0.02%)	⬇️
server	∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
client/src/app/api/rest.ts	54.94% <0.00%> (+0.31%)	⬆️
...s/components/application-form/application-form.tsx	55.66% <0.00%> (-0.16%)	⬇️
...ntities/components/identity-form/identity-form.tsx	56.32% <0.00%> (-0.13%)	⬇️

... and 27 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ibolton336]

Small change requested for old forEach / array.push style we are stylistically moving away from.

[ibolton336]

Suggested change

	let ids: number[] = [];
	applicationsToDelete.forEach((application) => {
	if (application.id) ids.push(application.id);
	});
	if (ids) bulkDeleteApplication({ ids: ids });
	setApplicationsToDelete([]);
	const ids = applicationsToDelete
	.filter(application=>application?.id)
	.map(application => application.id)
	//TODO should have some sort of loading state / error state before closing the modal just incase the bulk delete fails. Then we could move the setApplicatoinsToDelete to a success/error callback after the async operation rather than it being synchronous as it sits here.
	if (ids) bulkDeleteApplication({ ids: ids });
	setApplicationsToDelete([]);

[gildub]

@ibolton336, that's a good opportunity indeed.

[gildub]

@ibolton336, good idea to move setApplicationsToDelete to the success/error callbacks.
We don't really need to handle loading or error state when deleting items, the notification whether the delete operation is successful or fails, by providing information to the user.