Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Regroup shared and common components along naming standardization #1248

Merged
merged 4 commits into from
Aug 8, 2023
Merged

Conversation

gildub
Copy link
Contributor

@gildub gildub commented Aug 4, 2023

  • app/components: regroups app/shared/components, app/common/components and app/shared/containers
  • app/hooks: regroups app/shared/hooks
  • app/utils/: Now includes rules-utils from app/common/CustomRules/`

When not necessary the index.ts file has been removed.
Renamed component files using CamelCase.

See #1249

@gildub gildub requested a review from sjd78 August 4, 2023 13:59
@gildub gildub self-assigned this Aug 4, 2023
@gildub gildub changed the title ✨ Reorganized shared and common components and standardize ✨ regroup shared and common components along naming standardization Aug 4, 2023
@gildub gildub changed the title ✨ regroup shared and common components along naming standardization ✨ Regroup shared and common components along naming standardization Aug 4, 2023
Signed-off-by: Gilles Dubreuil <gdubreui@redhat.com>
Signed-off-by: Gilles Dubreuil <gdubreui@redhat.com>
Signed-off-by: Gilles Dubreuil <gdubreui@redhat.com>
Signed-off-by: Gilles Dubreuil <gdubreui@redhat.com>
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.34% ⚠️

Comparison is base (2909613) 43.61% compared to head (126158c) 43.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1248      +/-   ##
==========================================
- Coverage   43.61%   43.28%   -0.34%     
==========================================
  Files         173      143      -30     
  Lines        4457     4288     -169     
  Branches     1036      999      -37     
==========================================
- Hits         1944     1856      -88     
+ Misses       2434     2354      -80     
+ Partials       79       78       -1     
Flag Coverage Δ
client 43.28% <100.00%> (-0.34%) ⬇️
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
client/src/app/components/AppPlaceholder.tsx 100.00% <ø> (ø)
...plicationDependenciesFormContainer/FormContext.tsx 30.76% <ø> (ø)
client/src/app/components/BreadCrumbPath.tsx 100.00% <ø> (ø)
client/src/app/components/ConditionalRender.tsx 100.00% <ø> (ø)
client/src/app/components/ConfirmDialog.tsx 90.00% <ø> (ø)
client/src/app/components/EmptyTextMessage.tsx 100.00% <ø> (ø)
...src/app/components/FilterToolbar/FilterControl.tsx 37.50% <ø> (ø)
...src/app/components/FilterToolbar/FilterToolbar.tsx 21.05% <ø> (ø)
...ponents/FilterToolbar/MultiselectFilterControl.tsx 10.93% <ø> (ø)
...p/components/FilterToolbar/SearchFilterControl.tsx 20.00% <ø> (ø)
... and 84 more

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants