✨ Initial Assessment page

[gildub]

The hub is going to provide Questionnaire type so the legacy Questionnaire (in model.ts) is renamed PathfinderQuestionnaire which is likely to become obsolete.

This uses PF5 Dropdown for Kebab menu instead of deprecated Dropdown.

Resolves #1260

[codecov]

Codecov Report

Patch coverage: 62.50% and project coverage change: +0.03% 🎉

Comparison is base (db53222) 43.11% compared to head (c171cfc) 43.14%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1268      +/-   ##
==========================================
+ Coverage   43.11%   43.14%   +0.03%     
==========================================
  Files         143      143              
  Lines        4291     4299       +8     
  Branches     1000     1000              
==========================================
+ Hits         1850     1855       +5     
- Misses       2361     2364       +3     
  Partials       80       80              

Flag	Coverage Δ
client	43.14% <62.50%> (+0.03%)	⬆️
server	∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
client/src/app/layout/SidebarApp/SidebarApp.tsx	26.66% <ø> (ø)
client/src/app/api/rest.ts	54.78% <57.14%> (+0.04%)	⬆️
client/src/app/Paths.ts	90.24% <100.00%> (+0.24%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mturley]

Looking good, a couple small things.

[mturley]

Should we name this CustomQuestionnaire to distinguish it from PathfinderQuestionnaire rather than imply inheritance between the two? or is it intended that all questionnaires will eventually use this type and pathfinder objects will be deprecated?

[gildub]

@mturley, that's a good idea although my understanding is that Pathfinder objects are going to become obsolete.
Let me get confirmation that from the Hub team.
The other thing is the custom questionnaire is a subset of questionnaire because there are system questionnaire provided by Tackle.

[mturley]

if pathfinder will be removed eventually and we'll only have one questionnaire type, i'm fine with leaving the name as-is.

[mturley]

I suppose this is design feedback for Justin but it seems confusing to me that we'll now have two views called Assessment - one here and one as a tab in application inventory. I guess because this is under admin it makes sense, but I wonder if we should propose that the nav item and page title are called "Questionnaires" instead, and a subtitle in the page header could be used to explain that they are for assessment.

[gildub]

@mturley,
My understanding is that the Administrator -> Assessment page is actually displaying the questionnaires but the Required button activate those questionnaires to the default Assessment process.
So the Questionnaires.tsx page might actually not the correct name. I wonder if I should rename it now or wait.
Because this page handles Assessment settings.

[mturley]

yeah maybe Assessment Settings is a better name than Assessment then. I just find the current name potentially confusing to users.

[gildub]

@ibolton336, what do you think about renaming that page Assessment.tsx ?
Because the used case is about providing Administrator a way to control assessment, which starts with activating (Required column) questionnaires.

[ibolton336]

I still find that to be a naming conflict. I'd rather it be something like AssessmentTools/QuestionaireSettings/AssessmentSettings etc.