🐛 Add a fallback for issue title #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ibolton336
commented
Aug 9, 2023
ibolton336
commented
- In the event of a blank ruleReport.description, fallback to use the name or a hardcoded string to prevent an app crash
ibolton336
force-pushed
the
issue-desc-fallback
branch
from
119e8c4
to
6c87751
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1273 +/- ##
=======================================
Coverage 43.14% 43.14%
=======================================
Files 143 143
Lines 4299 4299
Branches 1000 1000
=======================================
Hits 1855 1855
Misses 2364 2364
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jortel
reviewed
Aug 9, 2023
...pages/issues/issue-detail-drawer/file-incidents-detail-modal/file-incidents-detail-modal.tsx
Outdated
Show resolved
Hide resolved
ibolton336
force-pushed
the
issue-desc-fallback
branch
from
7aac028
to
4ca4ea4
Compare
gildub
reviewed
Aug 10, 2023
ibolton336
force-pushed
the
issue-desc-fallback
branch
3 times, most recently
from
6caaeba
to
a47aa8d
Compare
sjd78
reviewed
Aug 10, 2023
Signed-off-by: ibolton336 <ibolton@redhat.com>
ibolton336
force-pushed
the
issue-desc-fallback
branch
from
a47aa8d
to
c0c309c
Compare
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.