✨ Add actions kebab to archetypes table with stub dropdown items #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1328 +/- ##
=======================================
Coverage 42.58% 42.58%
=======================================
Files 136 136
Lines 4220 4220
Branches 1000 1000
=======================================
Hits 1797 1797
Misses 2411 2411
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sjd78
approved these changes
Sep 1, 2023
mturley
added a commit
that referenced
this pull request
Sep 7, 2023
Part of #1264, followup to #1328.  Note that the change to the MSW mock is because that line was a typo that resulted in a 404 when deleting an archetype, the delete questionnaire endpoint is already mocked in its own file. --------- Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1264.
Uses the ActionsColumn component pattern introduced in #1314 to add a kebab menu for actions shown in this mockup. All 3 actions are currently stubs to unblock @sjd78 from integrating his Edit functionality. PR to implement Duplicate and Delete will be next.
Follows the pattern found in this PF example for "danger" menu items (red text below a separator): https://www.patternfly.org/components/menus/menu#danger-menu-item