✨ Selectors to uniquely identify dropdowns #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1345 +/- ##
=======================================
Coverage 41.43% 41.43%
=======================================
Files 137 137
Lines 4279 4279
Branches 1026 1026
=======================================
Hits 1773 1773
Misses 2418 2418
Partials 88 88
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gildub
changed the title
gildub
changed the title
Signed-off-by: Gilles Dubreuil <gdubreui@redhat.com>
Signed-off-by: Gilles Dubreuil <gdubreui@redhat.com>
…ns IDs Signed-off-by: Gilles Dubreuil <gdubreui@redhat.com>
gildub
changed the title
ibolton336
approved these changes
Sep 15, 2023
|
Very helpful PR @ibolton336 . Thanks for these changes. |
ibolton336
pushed a commit
that referenced
this pull request
Sep 25, 2023
…sExpandable prop in useTableControlProps (#1398) In #1345, we changed the structure of the expandable rows in the Migration Waves table and caused the `isExpanded` prop to be present on all rows (which should only be on the expanded content rows), which caused all rows to be hidden because it was false. This PR restores the intended structure: Each row is wrapped in a `<Tbody>` with the `isExpanded` prop, which contains two `<Tr>`s: one for the row itself and one for the expanded content. Also removes the `cursor: "pointer"` inline style on the `Tbody` which was causing the whole row to appear clickable even though only the expandable cells are clickable. Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ibragins explained QE needs :
We can see those IDs in action in current PR in applications-table-assessment.tsx.
Meanwhile that cannot be easliy added to the legacy tables (PF4 or PF5 deprecated table) because we don't have access to the wrapper component. Therefore will have to wait for legacy table migration to be finished first.
This applies to every page having a top kebab (Toolbar) and rows with several actions button/kebab:
On the MigrationWaves page, the deprecated dropdown has been replaced with PF5 version.
#443