🐛 allow svn source repos to be validated #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibolton336
force-pushed
the
fix-svn-url-validation
branch
from
b34dc26
to
687c5c5
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1346 +/- ##
=======================================
Coverage ? 42.39%
=======================================
Files ? 137
Lines ? 4291
Branches ? 1007
=======================================
Hits ? 1819
Misses ? 2460
Partials ? 12
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
gitdallas
approved these changes
Sep 11, 2023
Signed-off-by: ibolton336 <ibolton@redhat.com>
ibolton336
force-pushed
the
fix-svn-url-validation
branch
from
687c5c5
to
5d4440a
Compare
ibolton336
added a commit
to ibolton336/tackle2-ui
that referenced
this pull request
Sep 29, 2023
- Fixes customer case 03608826 "When setting up an a new application to be analysed by the MTA, we select Subversion as the repository type and enter the URL with the SVN protocol. The UI tells us that this is not a valid URL for a Subversion repository. Changing the URL protocol to HTTP makes the error go away but our department wide Subversion server is set to use only SVN protocol and cannot be changed. This leaves us unable to scan an application a Subversion hosted application with a valid SVN URL." Adds regex to allow SVN repos to be validated when adding as a source repo to applications Signed-off-by: ibolton336 <ibolton@redhat.com>
dymurray
pushed a commit
that referenced
this pull request
Oct 2, 2023
) (#1417) - Fixes customer case 03608826 "When setting up an a new application to be analysed by the MTA, we select Subversion as the repository type and enter the URL with the SVN protocol. The UI tells us that this is not a valid URL for a Subversion repository. Changing the URL protocol to HTTP makes the error go away but our department wide Subversion server is set to use only SVN protocol and cannot be changed. This leaves us unable to scan an application a Subversion hosted application with a valid SVN URL." Adds regex to allow SVN repos to be validated when adding as a source repo to applications Signed-off-by: ibolton336 <ibolton@redhat.com>
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"When setting up an a new application to be analysed by the MTA, we select Subversion as the repository type and enter the URL with the SVN protocol. The UI tells us that this is not a valid URL for a Subversion repository. Changing the URL protocol to HTTP makes the error go away but our department wide Subversion server is set to use only SVN protocol and cannot be changed. This leaves us unable to scan an application a Subversion hosted application with a valid SVN URL."
Adds regex to allow SVN repos to be validated when adding as a source repo to applications