✨ Add view archetypes page #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ibolton336
commented
Sep 20, 2023
ibolton336
commented
- Adds a new view to handle Multi-archetype dropdown for assessment-actions #1373
- Moves confirmation to assessment table for applications rather than the assessment applications view]
- Update modal to show all archetypes that conflict
- Pre render the archetype view page with the first associated archetype to the app
ibolton336
force-pushed
the
view-archetypes-by-app
branch
from
402fda1
to
b81d41b
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1381 +/- ##
==========================================
+ Coverage 41.44% 41.46% +0.01%
==========================================
Files 137 137
Lines 4292 4293 +1
Branches 1038 1038
==========================================
+ Hits 1779 1780 +1
Misses 2424 2424
Partials 89 89
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: ibolton336 <ibolton@redhat.com>
Signed-off-by: ibolton336 <ibolton@redhat.com>
ibolton336
force-pushed
the
view-archetypes-by-app
branch
from
2ee1d13
to
10007b5
Compare
sjd78
reviewed
Sep 20, 2023
| const [activeArchetype, setActiveArchetype] = React.useState<Ref | null>( | ||
| null | ||
| ); | ||
| useEffect(() => { |
There was a problem hiding this comment.
This can probably be replaced with useMemo()
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.