Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Add missing clear handler for app import #1400

Merged
merged 4 commits into from
Sep 26, 2023

Conversation

ibolton336
Copy link
Member

Signed-off-by: ibolton336 <ibolton@redhat.com>
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (fbd5e3d) 41.31% compared to head (dc1c7b5) 41.37%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1400      +/-   ##
==========================================
+ Coverage   41.31%   41.37%   +0.06%     
==========================================
  Files         138      138              
  Lines        4330     4326       -4     
  Branches     1035     1037       +2     
==========================================
+ Hits         1789     1790       +1     
+ Misses       2453     2448       -5     
  Partials       88       88              
Flag Coverage Δ
client 41.37% <54.54%> (+0.06%) ⬆️
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/src/app/components/MenuActions.tsx 100.00% <100.00%> (ø)
client/src/app/components/TargetCard.tsx 16.92% <ø> (-1.26%) ⬇️
client/src/app/layout/HeaderApp/MobileDropdown.tsx 90.00% <100.00%> (+16.66%) ⬆️
client/src/app/components/KebabDropdown.tsx 83.33% <71.42%> (+50.00%) ⬆️
client/src/app/layout/HeaderApp/SSOMenu.tsx 53.57% <0.00%> (-3.58%) ⬇️
...src/app/components/FilterToolbar/FilterToolbar.tsx 19.29% <0.00%> (-1.76%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants