Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix(autocomplete): tags not generated for preselected options #1403

Merged
merged 7 commits into from
Sep 27, 2023
Merged

🐛 fix(autocomplete): tags not generated for preselected options #1403

merged 7 commits into from
Sep 27, 2023

Commits on Sep 26, 2023

  1. fix(autocomplete): tags not generated for preselected options 

    Signed-off-by: gitdallas <dallas.nicol@gmail.com>
    @gitdallas
    gitdallas committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    740f388 View commit details
    Browse the repository at this point in the history

  2. cleanup commented code 

    Signed-off-by: gitdallas <dallas.nicol@gmail.com>
    @gitdallas
    gitdallas committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    16b6d20 View commit details
    Browse the repository at this point in the history

  3. cleanup, stick with selection naming rather than sometimes chip 

    Signed-off-by: gitdallas <dallas.nicol@gmail.com>
    @gitdallas
    gitdallas committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    431d8b4 View commit details
    Browse the repository at this point in the history

  4. filter out tags that have a non-falsey source value 

    Signed-off-by: gitdallas <dallas.nicol@gmail.com>
    @gitdallas
    gitdallas committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    53069c0 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. use set for tag options, filter shown tags with other source 

    Signed-off-by: gitdallas <dallas.nicol@gmail.com>
    @gitdallas
    gitdallas committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    ba418c1 View commit details
    Browse the repository at this point in the history

  2. remove console log 

    Signed-off-by: gitdallas <dallas.nicol@gmail.com>
    @gitdallas
    gitdallas committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    d2cb75b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fix/j1315-existing-autocomplete-tags-not-sho… 

    …wing
    @ibolton336
    ibolton336 authored Sep 27, 2023
    Configuration menu
    Copy the full SHA
    7a832ca View commit details
    Browse the repository at this point in the history