🌱 Add global ci #1405
Merged
🌱 Add global ci #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1405 +/- ##
=======================================
Coverage 39.41% 39.41%
=======================================
Files 146 146
Lines 4775 4775
Branches 1138 1138
=======================================
Hits 1882 1882
Misses 2879 2879
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dymurray
approved these changes
Oct 2, 2023
sjd78
reviewed
Oct 13, 2023
Comment on lines
+74
to
+78
| test-integration: | ||
| needs: build-and-upload-for-global-ci | ||
| uses: konveyor/ci/.github/workflows/global-ci.yml@main | ||
| with: | ||
| component_name: tackle2-ui |
There was a problem hiding this comment.
Does it make sense to run the both api integration and ui tests as part of UI CI?
The UI tests make sense, but the api tests seem unnecessary.
There was a problem hiding this comment.
@sjd78 reasonable since these shouldn't affect the API at all. We should have e2e ui tests running soon. Will update the PR when that's up
There was a problem hiding this comment.
@sjd78 it will now only run the UI tests
fabianvf
force-pushed
the
global-ci
branch
2 times, most recently
from
cccc5f1
to
fbe502c
Compare
Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
sjd78
approved these changes
Nov 22, 2023
ibolton336
approved these changes
Nov 27, 2023
This was referenced Dec 11, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global CI Integration for Component Builds
This PR integrates a GitHub Action workflow to build and upload the component images, preparing them for the global CI system.
By integrating the global CI, we aim to streamline and standardize our CI process across all components, ensuring a more efficient and unified CI/CD pipeline.