Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Applications form: Fix contributors and tags field handling #1408

Merged
merged 4 commits into from
Sep 28, 2023
Merged

🐛 Applications form: Fix contributors and tags field handling #1408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8317981
Applications form: Fix contributors field handling (and other stuff)
sjd78 Sep 27, 2023
14e1a8e
Application Form: Tweak tagCategory, tags, tagOptions handling
sjd78 Sep 28, 2023
d8d5cb8
Refactor `ApplicationForm`
sjd78 Sep 28, 2023
05f0f8a
Fixup naming of *toRef() helper functions
sjd78 Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions client/src/app/api/rest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,11 +117,11 @@

type Direction = "asc" | "desc";

const buildQuery = (params: any) => {

Check warning on line 120 in client/src/app/api/rest.ts

View workflow job for this annotation

GitHub Actions / unit-test (18.x) 

'buildQuery' is assigned a value but never used

Check warning on line 120 in client/src/app/api/rest.ts

View workflow job for this annotation

GitHub Actions / unit-test (18.x) 

Unexpected any. Specify a different type
const query: string[] = [];

Object.keys(params).forEach((key) => {
const value = (params as any)[key];

Check warning on line 124 in client/src/app/api/rest.ts

View workflow job for this annotation

GitHub Actions / unit-test (18.x) 

Unexpected any. Specify a different type

if (value !== undefined && value !== null) {
let queryParamValues: string[] = [];
Expand Down Expand Up @@ -271,8 +271,8 @@

// Axios direct

export const createApplication = (obj: Application): Promise<Application> =>
axios.post(`${APPLICATIONS}`, obj);
export const createApplication = (data: Application) =>
axios.post<Application>(`${APPLICATIONS}`, data);

Check warning on line 275 in client/src/app/api/rest.ts

View check run for this annotation

Codecov / codecov/patch

client/src/app/api/rest.ts#L275 

Added line #L275 was not covered by tests

export const deleteApplication = (id: number): Promise<Application> =>
axios.delete(`${APPLICATIONS}/${id}`);
Expand Down
Loading
Loading