🐛 Add tooltip for weight column #1433
Conversation
ibolton336
commented
Oct 4, 2023
ibolton336
commented
- Adds tooltip to weight answer table column https://issues.redhat.com/browse/MTA-1351?filter=-1
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1433 +/- ##
=======================================
Coverage 41.07% 41.07%
=======================================
Files 139 139
Lines 4404 4404
Branches 1010 1010
=======================================
Hits 1809 1809
Misses 2583 2583
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| {...getThProps({ columnKey: "weight" })} | ||
| info={{ | ||
| tooltip: | ||
| "This column shows the associated risk weight of an answered question. A red 'X' icon indicates High risk, a yellow warning icon indicates Medium risk, and a green checkmark indicates Low risk.", |
There was a problem hiding this comment.
Since the tooltip prop can be a ReactNode, I'd rather see a better styled tooltip:
tooltip: (
<TextContent>
<Text>This column shows the associated risk weight of an answered question.</Text>
<List isPlain>
<ListItem>{getIconByRisk("red")} is High risk</ListItem>
<ListItem>{getIconByRisk("yellow")} is Medium risk</ListItem>
<ListItem>{getIconByRisk("green")} is Low risk</ListItem>
</List>
</TextContent>
),Doing some i18n and adding the messages to translation.json would be nice.
There was a problem hiding this comment.
For some reason this is the result of the tooltip with ReactNode elements
this looks great |
There was a problem hiding this comment.
Given @JustinXHale 's approval, this is ok with me. I still recommend the tooltip content change, but it is not a blocker.
|
|
Signed-off-by: ibolton336 <ibolton@redhat.com>
