Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ refelect ID -> Id #1482

Merged
merged 3 commits into from
Oct 19, 2023
Merged

✨ refelect ID -> Id #1482

merged 3 commits into from
Oct 19, 2023

Conversation

sarthaksarthak9
Copy link
Contributor

@sarthaksarthak9 sarthaksarthak9 commented Oct 17, 2023

Appears that konveyor have since settled on "ID->Id". There are still a few places where we need to reflect this decision in the code. E.g. getKindIDByRef, useFetchBusinessServiceByID, etc

closes #1307

Signed-off-by: sarthaksarthak9 <sarthaknegi908@gmail.com>
Signed-off-by: sarthaksarthak9 <sarthaknegi908@gmail.com>
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. The PR needs to be rebased to main with a merge conflict resolved. With a rebase, should be all set!

@sarthaksarthak9
Copy link
Contributor Author

The changes look good. The PR needs to be rebased to main with a merge conflict resolved. With a rebase, should be all set!

yah sure!!

Signed-off-by: Sarthak Negi <122533767+sarthaksarthak9@users.noreply.github.com>
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ba66b4f) 40.69% compared to head (7307f54) 40.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1482   +/-   ##
=======================================
  Coverage   40.69%   40.69%           
=======================================
  Files         139      139           
  Lines        4463     4463           
  Branches     1067     1067           
=======================================
  Hits         1816     1816           
  Misses       2552     2552           
  Partials       95       95           
Flag Coverage Δ
client 40.69% <100.00%> (ø)
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/src/app/queries/businessservices.ts 30.76% <100.00%> (ø)
client/src/app/utils/model-utils.tsx 35.06% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize on which form of (byID || byId) to use
2 participants